[PATCH] D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 11:48:21 PDT 2019


bjope added inline comments.


================
Comment at: llvm/test/CodeGen/X86/mulfix_combine.ll:16
 ; CHECK-NEXT:    xorl %eax, %eax
-; CHECK-NEXT:    shrdl $2, %eax, %eax
 ; CHECK-NEXT:    retq
----------------
X86 backend seem to introduce taget specific DAG nodes for shifts early (without simplifying shift of zero)?
So this might display a more general problem in the X86 backend.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66052/new/

https://reviews.llvm.org/D66052





More information about the llvm-commits mailing list