[PATCH] D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a reviewer: dmgreen.
lebedev.ri added a comment.

Thank you for taking a look!

In D65148#1631933 <https://reviews.llvm.org/D65148#1631933>, @dmgreen wrote:

> Fair enough.




> One last issue, which might come up from this change. This time with a multiply, that was previously able to simplify one of the compares to true, I think in CVP.  Same __SSAT as before.
> 
>   void arm_mult_q7(const signed char * pSrcA, const signed char * pSrcB, signed char * pDst, unsigned  blockSize)
>   {
>     unsigned  blkCnt = blockSize;
>     while (blkCnt > 0U)
>     {
>       *pDst++ = (signed char) __SSAT((((short) (*pSrcA++) * (*pSrcB++)) >> 7), 8);
>       blkCnt--;
>     }
>   }

Interesting, so https://godbolt.org/z/No06Qq
I'm not sure what fold exactly is missing there yet, i think it could be constant range?
@nikic, is that something you might be interested looking into? :)

> i.e this: https://rise4fun.com/Alive/fplbG




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65148/new/

https://reviews.llvm.org/D65148