[PATCH] D66224: MemoryBuffer: Add a missing error-check to getOpenFileImpl

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 10:49:07 PDT 2019


labath added a comment.

Ok, I have an idea what's going on. There's a difference in the behavior of `readNativeFileSlice` on windows&posix, and neither of them really do what MemoryBuffer expects here. I don't have time to fix this today so I'll revert and get back to this tomorrow. Thanks for the heads up.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66224/new/

https://reviews.llvm.org/D66224





More information about the llvm-commits mailing list