[PATCH] D65859: [LLVM][Alignment] Fix MSVC warning

Greg Bedwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 06:35:56 PDT 2019


gbedwell added a comment.

I've not tested, but it seems reasonable.  The only other "#pragma warning" I came across (in the neighbouring llvm/unittests/Support/AlignOfTest.cpp) doesn't bother with a push/pop and just disables the warnings at file scope.  I'm not sure if there's any reason to push/pop across the entire file unless we think we might want to ever include this cpp file inside another one?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65859/new/

https://reviews.llvm.org/D65859





More information about the llvm-commits mailing list