[PATCH] D66253: [NewPM][PassInstrumentation] IR printing support for (Thin)LTO

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 05:38:35 PDT 2019


tejohnson added a comment.

Thanks for fixing this. Comment on the test case below.



================
Comment at: llvm/test/LTO/X86/printer.ll:1
+; RUN: clang -flto -fexperimental-new-pass-manager -Wl,-plugin-opt,-print-before-all %s %p/Inputs/printer.ll -o - 2>&1 | FileCheck %s --check-prefix=CHECK-BEFORE
+; RUN: clang -flto -fexperimental-new-pass-manager -Wl,-plugin-opt,-print-after-all %s %p/Inputs/printer.ll -o - 2>&1 | FileCheck %s --check-prefix=CHECK-AFTER
----------------
This relies on invoking the backend via clang invoking the linker, which we don't generally do in the llvm tests and is probably not a good idea. Just use llvm-lto2. That should also make it easier to simplify down to a single input file - you should only need one file with one function to test this behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66253/new/

https://reviews.llvm.org/D66253





More information about the llvm-commits mailing list