[PATCH] D65368: [DebugInfo] Handle complex expressions of spilt locations in LiveDebugValues

[Jeremy Morse via Phabricator via llvm-commits]

jmorse updated this revision to Diff 215363.
jmorse added a comment.

Rebase onto the crash-fixing patch in D66284 <https://reviews.llvm.org/D66284>. This patch now removes the crash-fixing workaround that salvages fragments from spilt expressions, in favour of a more generalised method to access the original unspilt expression. I've edited the details of that into the patch summary at the top.

Adrian wrote:

> I think you are right in that patch 1 is safe standalone, since the lifetime will end naturally because of the clobber. Patch 2 introduces a new DBG_VALUE, clobbering any previous DBG_VALUE so it is naturally safe, too. And I think the same argument even holds for patch 3.

Cool, sounds like we're all in agreement, patches 1 and 2 are now arranged in phabricator.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65368/new/

https://reviews.llvm.org/D65368

Files:
  lib/CodeGen/LiveDebugValues.cpp
  test/DebugInfo/MIR/X86/live-debug-values-restore.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65368.215363.patch
Type: text/x-patch
Size: 15469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190815/7df9a0fb/attachment.bin>