[PATCH] D66277: [ELF][AArch64] Improve error message for unknown relocations

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 02:10:14 PDT 2019


peter.smith added a comment.

Looks good to me. George's suggestion for a test is a good one. From a brief look some of the other targets also return R_ABS by default from getRelExpr, such as ARM, PPC, PPC64, Hexagon, MSP430, AVR. I don't think it is worth applying this method universally to all of them, but it may be worth ARM, PPC and PPC64. When this goes in I'd be happy to submit a similar patch for ARM.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66277/new/

https://reviews.llvm.org/D66277





More information about the llvm-commits mailing list