[PATCH] D65020: [GVN] Do PHI translations across all edges between the load and the unavailable pred.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 15:10:55 PDT 2019


efriedma added a comment.

Given that each block only has a single predecessor, there aren't any PHI nodes involved.  In that case, what does PHITranslateWithInsertion actually do?



================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1204
+      // trying to number them.
+      NewInsts.pop_back_val()->eraseFromParent();
     }
----------------
I don't see any explanation for this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65020/new/

https://reviews.llvm.org/D65020





More information about the llvm-commits mailing list