[PATCH] D66139: [RISCV] Support llvm-objdump -M no-aliases and -M numeric

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.

LGTM.



================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVInstPrinter.cpp:43
 static cl::opt<bool>
     ArchRegNames("riscv-arch-reg-names",
                  cl::desc("Print architectural register names such as x0-x31 "
----------------
The patch should probably mention that it builds upon D65950, which introduces `ArchRegNames`.


================
Comment at: llvm/test/CodeGen/RISCV/compress-inline-asm.ll:2
 ; RUN: llc -mtriple=riscv32 -mattr=+c  -filetype=obj < %s\
-; RUN: | llvm-objdump -triple=riscv32 -mattr=+c -d -riscv-no-aliases -\
+; RUN: | llvm-objdump -triple=riscv32 -mattr=+c -d -M no-aliases -\
 ; RUN: | FileCheck -check-prefix=CHECK %s
----------------
Is it worth keeping at least one test using the old `-riscv-no-aliases`, to be sure that option also keeps working?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66139/new/

https://reviews.llvm.org/D66139