[PATCH] D65026: [Bugpoint redesign] Added pass to reduce Metadata

[Diego Treviño via Phabricator via llvm-commits]

diegotf marked 3 inline comments as done.
diegotf added inline comments.


================
Comment at: llvm/test/Reduce/remove-metadata.ll:1
+; Test that llvm-reduce can remove uninteresting metadata from an IR file.
+; The Metadata pass erases named & unnamed metadata nodes, as well as debug functions.
----------------
dblaikie wrote:
> Would it be possible to test this without specifically debug info metadata?  If the feature is general over all metadata it might be clearer to demonstrate with less IR (fewer metadata nodes, if they don't have to form a complete debug info metadata graph, etc).
Agreed, I'll modify the test so it only contains fewer unnamed metadata nodes (and no `!dbg` metadata)


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceMetadata.cpp:10-11
+// This file implements two functions used by the Generic Delta Debugging
+// Algorithm, which are used to reduce Metadata tags, as well as debug
+// functions.
+//
----------------
dblaikie wrote:
> Any reason debug functions would need to be a special case here, rather than handled as a consequence of a general pass that removes any functions?
Yeah, since `ReduceFunctions.cpp` only considers //defined// functions, they would be ignored. Though I've been thinking about changing that lately...

I'll cook up a quick diff so this pass doesn't have to consider debug functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65026/new/

https://reviews.llvm.org/D65026