[PATCH] D66236: [SDAG][x86] check for relaxed math when matching an FP reduction

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 12:46:24 PDT 2019


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:9013
+      return SDValue();
+  }
 
----------------
Is this satisfactory for all possible float ops (FMUL/FMIN/etc)? Also, shouldn't we be testing this at every stage?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66236/new/

https://reviews.llvm.org/D66236





More information about the llvm-commits mailing list