[PATCH] D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors

Denis Bakhvalov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 11:01:05 PDT 2019


dendibakh marked 2 inline comments as done.
dendibakh added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp:364
   void getAnalysisUsage(AnalysisUsage &AU) const override {
-    AU.setPreservesCFG();
     AU.addRequired<AAResultsWrapperPass>();
----------------
Maybe we can invalidate only if new BB was created.


================
Comment at: llvm/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp:394
   PreservedAnalyses PA;
-  PA.preserveSet<CFGAnalyses>();
   PA.preserve<GlobalsAA>();
----------------
Maybe we can invalidate only if new BB was created.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66234/new/

https://reviews.llvm.org/D66234





More information about the llvm-commits mailing list