[PATCH] D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek accepted this revision.
kubamracek added a comment.
This revision is now accepted and ready to land.

LGTM, even if it's just for Darwin now.

I do think, though, that LLVMSymbolizerProcess should also use posix_spawn *on Darwin*. Can we get that (as a separate change)?



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_mac.cc:257
+  master_fd = posix_openpt(O_RDWR);
+  if (master_fd == kInvalidFd) return kInvalidFd;
+
----------------
There's a bunch of different reasons why we can fail to spawn. Should we Report() to log the actual failed API?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65253/new/

https://reviews.llvm.org/D65253