[PATCH] D66217: [BuildLibCalls] Noalias annotation

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 08:28:06 PDT 2019


jdoerfert added inline comments.


================
Comment at: lib/Transforms/Utils/BuildLibCalls.cpp:263
     Changed |= setDoesNotCapture(F, 0);
+    Changed |= setDoesNotAlias(F, 0);
     Changed |= setDoesNotCapture(F, 1);
----------------
xbolva00 wrote:
> jdoerfert wrote:
> > I'm not sure what this means or what this is going to help, but maybe I just miss something.
> Target buffer may not overlap with other args.
> 
> I can remove it, but some future optimizations based on noalias info would be weaker.
I was wrong, if that is the `sprintf` semantics, keep it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66217/new/

https://reviews.llvm.org/D66217





More information about the llvm-commits mailing list