[PATCH] D66170: InferAddressSpaces: Move target intrinsic handling to TTI

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 06:37:40 PDT 2019


hliao added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:374
+  /// was handled.
+  bool rewriteIntrinsicWithAddressSpace(IntrinsicInst *II,
+                                        Value *OldV, Value *NewV) const;
----------------
In general, we need to tell the value use, says save a generic pointer to somewhere, of a pointer from its address use. Only the later needs address-space resolving or inferring. It would be better to add the extra opnd index to help the target checks that case and only rewrite the address use.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66170/new/

https://reviews.llvm.org/D66170





More information about the llvm-commits mailing list