[PATCH] D66078: Added RAII object for authomatic restore of fp state

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicInst.h:220
+      rmDynamic          ///< This corresponds to "fpround.dynamic".
     };
 
----------------
sepavloff wrote:
> kpn wrote:
> > What does this change give us? Having rmDynamic == 0 means that if a bug causes it to be zero initialized we get the most conservative behavior from the compiler. What's the tradeoff? And where is this change tested?
> The intention was to have zero value as the default for `RoundingMode`, which is used when no constrained operation required.  `ExceptionBehavior` does this: `ebIgnore` means no special exception behavior is requested. In this case non-zero value indicates that we have to process operation in a special way.
> 
> This change is a matter of convenience, it isn't strictly necessary for this patch. If you think it shouldn't go to sources, i'll remove it.
Yeah, we're inconsistent. I'd like to resolve that inconsistency another day. Please remove this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66078/new/

https://reviews.llvm.org/D66078