[PATCH] D66214: [ARM] Use MQPR not QPR for MVE registers
Oliver Stannard (Linaro) via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 14 06:05:05 PDT 2019
ostannard added inline comments.
================
Comment at: llvm/test/CodeGen/Thumb2/mve-crash-qpr.ll:10
+; CHECK: @ %bb.0: @ %entry
+; CHECK-NEXT: .save {r4, r5, r6, r7, r8, r9, lr}
+; CHECK-NEXT: push.w {r4, r5, r6, r7, r8, r9, lr}
----------------
I don't think these check lines are really adding any value, this is a complex test file so we'd expect the generated code to change as we improve the MVE code generation. Could we instead test this by stopping as soon as possible after instruction selection, and checking that the vregs are all MQPR class in the MIR? That would also allow the IR to be greatly reduced.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66214/new/
https://reviews.llvm.org/D66214
More information about the llvm-commits
mailing list