[PATCH] D66148: [SemanticTypedef] Provide a semantic typedef class and operators

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 00:51:00 PDT 2019


labath added inline comments.


================
Comment at: llvm/include/llvm/ADT/SemanticTypedef.h:1
+//===-- SemanticTypedef.h - Typedefs for a type-safe world ------*- C++ -*-===//
+//
----------------
I know this has been discussed on the thread, but I feel obligated to point out that there is already precedent for using the term "strong typedef" for this kind of thing: `LLVM_YAML_STRONG_TYPEDEF`. Might not matter if the goal is to eventually replace LLVM_YAML_STRONG_TYPEDEF with this, but otherwise, it would be nice to maintain consistent naming within the project.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66148/new/

https://reviews.llvm.org/D66148





More information about the llvm-commits mailing list