[llvm] r368797 - Don't run a full verifier pass in coro-splitting's private pipeline.

John McCall via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 20:54:19 PDT 2019


Author: rjmccall
Date: Tue Aug 13 20:54:18 2019
New Revision: 368797

URL: http://llvm.org/viewvc/llvm-project?rev=368797&view=rev
Log:
Don't run a full verifier pass in coro-splitting's private pipeline.

Potentially addresses rdar://49022293.

Modified:
    llvm/trunk/lib/Transforms/Coroutines/CoroSplit.cpp

Modified: llvm/trunk/lib/Transforms/Coroutines/CoroSplit.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Coroutines/CoroSplit.cpp?rev=368797&r1=368796&r2=368797&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Coroutines/CoroSplit.cpp (original)
+++ llvm/trunk/lib/Transforms/Coroutines/CoroSplit.cpp Tue Aug 13 20:54:18 2019
@@ -865,9 +865,14 @@ static void updateCoroFrame(coro::Shape
 
 static void postSplitCleanup(Function &F) {
   removeUnreachableBlocks(F);
+
+  // For now, we do a mandatory verification step because we don't
+  // entirely trust this pass.  Note that we don't want to add a verifier
+  // pass to FPM below because it will also verify all the global data.
+  verifyFunction(F);
+
   legacy::FunctionPassManager FPM(F.getParent());
 
-  FPM.add(createVerifierPass());
   FPM.add(createSCCPPass());
   FPM.add(createCFGSimplificationPass());
   FPM.add(createEarlyCSEPass());




More information about the llvm-commits mailing list