[PATCH] D66075: [llvm-readobj][MachO] Fix section type printing

Seiya Nuta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 18:24:42 PDT 2019


seiya marked 2 inline comments as done.
seiya added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/macho-sections.test:51
+    Sections:
+      - sectname:        ''
+        segname:         ''
----------------
jhenderson wrote:
> Are all fields required, or can some be omitted? Same goes throughout the YAML.
Yes they are. (I was wondering about that the whole time and I'd like to make some of them optional at some time if possible)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66075/new/

https://reviews.llvm.org/D66075





More information about the llvm-commits mailing list