[PATCH] D63676: Early exit from Hoist() in machine licm pass based on block hotness

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 16:32:26 PDT 2019


efriedma added a comment.

In the future, please try to ping more frequently than once a month; we don't want to lose patches, even if there are some areas where it takes a while to get review.

The general idea of avoiding hoisting that would increase the frequency makes sense.

Could you give some idea what effect this has in practice?  How often does this trigger on SPEC?  Does it affect SPEC performance or size numbers?  (Replace SPEC with some similar benchmark if you prefer.)

Is there anything special about the number "100"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63676/new/

https://reviews.llvm.org/D63676





More information about the llvm-commits mailing list