[PATCH] D65977: [Attributor] Use IRPosition consistently

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 accepted this revision.
sstefan1 added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:158
+  static const IRPosition value(const Value &V, const Function &AnchorScope) {
+    // TODO: Determine if we need the scope at all.
+    if (auto *Arg = dyn_cast<Argument>(&V))
----------------
jdoerfert wrote:
> sstefan1 wrote:
> > uenoku wrote:
> > >  What are the advantages to record the scope? 
> > I don't see the need for it.
> We could then tie constants to functions, but again, I was also not sure why/if we want that.
Ok, so we keep that for now (as it can't do no harm) and see how things go?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65977/new/

https://reviews.llvm.org/D65977