[PATCH] D66171: [GlobalISel]: Fix lowering of G_SHUFFLE_VECTOR with scalar sources

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 14:43:03 PDT 2019


aditya_nandakumar added a comment.

In D66171#1627953 <https://reviews.llvm.org/D66171#1627953>, @arsenm wrote:

> LGTM, although I rather dislike that we allow these. Maybe the IRTranslator should be trying to turn these into the equivalent G_BUILD_VECTOR?


Thanks for the quick review.
I agree that this is messy. Turning it into BUILD_VECTOR seems to be like an optimization for now - but I don't really have a better solution. It's probably worth creating a patch and seeing what others think about it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66171/new/

https://reviews.llvm.org/D66171





More information about the llvm-commits mailing list