[PATCH] D66147: [TextAPI] Update reader to be supported by lib/Object

Cyndy Ishida via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 13:33:50 PDT 2019


cishida marked an inline comment as done.
cishida added a comment.

I currently don't have commit access, so would anyone mind pushing this up to master?



================
Comment at: llvm/include/llvm/TextAPI/MachO/TextAPIReader.h:25
-
-  static Expected<std::unique_ptr<InterfaceFile>>
-  getUnmanaged(llvm::MemoryBuffer *InputBuffer);
----------------
steven_wu wrote:
> What happened to this function? Is this declared and never implemented?
yep, never created an error because it was never called by anything 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66147/new/

https://reviews.llvm.org/D66147





More information about the llvm-commits mailing list