[PATCH] D65542: [PeepholeOptimizer] Don't assume bitcast def always has input

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 10:00:36 PDT 2019


qcolombet added a comment.

LGTM with a test case.



================
Comment at: llvm/lib/CodeGen/PeepholeOptimizer.cpp:1858
 
+  // In some rare case, the Def has not input, SrcIdx is out of bound,
+  // getOperand(SrcIdx) will fail below.
----------------
Nit: Def has no input.

(remove "the" and the t from "not")


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65542/new/

https://reviews.llvm.org/D65542





More information about the llvm-commits mailing list