[PATCH] D65189: [MC] Support returning a structured rich disassembly output

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 08:59:48 PDT 2019


jhenderson added a comment.

You should update your patch title and description too.



================
Comment at: llvm/include/llvm/MC/MCInstPrinter.h:74
+/// should be instantiated through MCInstPrinter::startMarkup() and
+/// MCInstPrinter::startMarkup() respectively:
+///
----------------
This comment doesn't make much sense (it refers to startupMarkup() too many times, I think). Please fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65189/new/

https://reviews.llvm.org/D65189





More information about the llvm-commits mailing list