[PATCH] D66109: GlobalISel: Change representation of shuffle masks

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 07:42:57 PDT 2019


aditya_nandakumar added a comment.

In D66109#1626195 <https://reviews.llvm.org/D66109#1626195>, @arsenm wrote:

> In D66109#1626112 <https://reviews.llvm.org/D66109#1626112>, @aditya_nandakumar wrote:
>
> > Thanks for doing this. Overall the patch LGTM. On a side note, should we try to document all the links we have to IR in GlobalISel somewhere?
>
>
> Not sure where that would go


Perhaps in the bottom of https://www.llvm.org/docs/GlobalISel.html ? Alternatively we can document in GenericOpcodes.td right along the instructions which have links.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66109/new/

https://reviews.llvm.org/D66109





More information about the llvm-commits mailing list