[PATCH] D66134: [llvm-size][test] Improve llvm-size testing

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/llvm-size/common.test:8
+# RUN: llvm-size -A %t.o | FileCheck --check-prefix=SYSVNOCOMM %s
+# RUN: llvm-size -B %t.o | FileCheck --check-prefix=BSDNOCOMM %s
 
----------------
jhenderson wrote:
> grimar wrote:
> > nit: since `--common` is not the default, perhaps it should be `SYSV` + `SYSVCOMMON`?
> > Up to you.
> I was sticking with the existing prefixes for this test, so would prefer not to change it, though I don't feel strongly about it.
I see. It's ok to stick to the existent naming I think. I did not notice it was the original naming.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66134/new/

https://reviews.llvm.org/D66134