[PATCH] D65950: [RISCV] Add Option for Printing Architectural Register Names

[Sam Elliott via Phabricator via llvm-commits]

lenary marked an inline comment as done.
lenary added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVInstPrinter.cpp:43
+static cl::opt<bool>
+    ArchRegNames("riscv-arch-reg-names",
+                 cl::desc("Print architectural register names such as x0-x31 "
----------------
apazos wrote:
> Do we really need another flag? Or can we just reuse riscv-no-aliases?
> 
> I think with GNU toolchain, and when calling llvm-mc/llvm-objdump , -M no-aliases will avoid printing any aliases including architecture aliases. There is no separate flag for controlling printing arch reg names.
I checked with my version of objdump (seems to be version 2.32) and it separates `-M no-aliases` and `-M numeric` (the latter of which prints the architectural register names). I'm happy to rename the flag, but the flags do seem to be separate. 

I also thought a separate flag would be a less invasive change.

This flag definition becomes the definition for llvm-mc, and we don't yet support target-specific options using the `-M` flag for risc-v (but we should).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65950/new/

https://reviews.llvm.org/D65950