[PATCH] D66130: [ELF] Initialize 2 fields of Symbol in SymbolTable::insert

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM. Please wait for other reviewer(s) opinion about comments (I'd remove them).



================
Comment at: ELF/SymbolTable.cpp:75
+  // Fields referenced by Symbol::mergeProperties and Symbol::replace must be
+  // initialized here.
   sym->setName(name);
----------------
I am not sure that comments of this patch are valuable. You just initializing fields
because they can be used anywhere in LLD. Not sure it is worth to mention where
they are used/copied.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66130/new/

https://reviews.llvm.org/D66130