[PATCH] D66108: [LV] fold-tail flag

Mon Aug 12 23:35:20 PDT 2019

SjoerdMeijer added inline comments.

================
Comment at: test/Transforms/LoopVectorize/X86/tail_loop_folding.ll:2
 ; RUN: opt < %s -loop-vectorize -S | FileCheck %s
+; RUN: opt < %s -loop-vectorize -prefer-predicate-over-epilog -S | FileCheck -check-prefix=PREDFLAG %s

----------------
Because these test cases have the `vectorize.predicate.enable` metadata set, I am not sure we are actually testing this new option. I don't think so, I think we need a separate function without the predicate metadata.

================
Comment at: test/Transforms/LoopVectorize/X86/tail_loop_folding.ll:17
 ; CHECK:  br i1 %12, label %middle.block, label %vector.body, !llvm.loop !0
-
+; PREDFLAG-LABEL: tail_folding_enabled(
+; PREDFLAG:  vector.body:
----------------
I expect the output to be the same whether a pragma was used or this new options, so can we just use the CHECK tag?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66108/new/

https://reviews.llvm.org/D66108