[PATCH] D66091: [ELF] Simplify handling of exportDynamic and isPreemptible

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 22:19:13 PDT 2019


MaskRay updated this revision to Diff 214758.
MaskRay marked 4 inline comments as done.
MaskRay edited the summary of this revision.
MaskRay added a comment.

Given it more thought. Rather than extracting -shared or --export-dynamic logic outside exportDynamic,
we should instead pull the --dynamic-list information out.

Delete canOmitFromDynSym and add inDynamicList instead.

Added a new test dynamic-list-preempt2.s in rLLD368649 <https://reviews.llvm.org/rLLD368649> to test some interaction between exportDynamic is isPreemptible.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66091/new/

https://reviews.llvm.org/D66091

Files:
  ELF/SymbolTable.cpp
  ELF/Symbols.cpp
  ELF/Symbols.h
  ELF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66091.214758.patch
Type: text/x-patch
Size: 4614 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190813/02aac511/attachment.bin>


More information about the llvm-commits mailing list