[PATCH] D66111: GlobalISel: Implement lower for G_SHUFFLE_VECTOR

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3774
+  auto MIB = MIRBuilder.buildInstrNoInsert(TargetOpcode::G_BUILD_VECTOR)
+    .addDef(DstReg);
+
----------------
aditya_nandakumar wrote:
> Would it be possible to buildInstr in a way that it can be CSE'd (collect the regs in a SmallVector and build in the end)?
> While I think the chances of CSEing a G_BUILD_VECTOR is quite low, it probably doesn't hurt to enable it.
It's possible, but I find the intermediate vectors for these sorts of things kind of annoying to use and it seemed more straightforward to add operands directly


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66111/new/

https://reviews.llvm.org/D66111