[llvm] r368611 - Revert "Disable MachO TBD write tests for Windows."

Juergen Ributzka via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 12:51:34 PDT 2019


Author: ributzka
Date: Mon Aug 12 12:51:34 2019
New Revision: 368611

URL: http://llvm.org/viewvc/llvm-project?rev=368611&view=rev
Log:
Revert "Disable MachO TBD write tests for Windows."

The underlying issue was fixed in r357759.

Modified:
    llvm/trunk/unittests/TextAPI/TextStubV1Tests.cpp
    llvm/trunk/unittests/TextAPI/TextStubV2Tests.cpp

Modified: llvm/trunk/unittests/TextAPI/TextStubV1Tests.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/TextAPI/TextStubV1Tests.cpp?rev=368611&r1=368610&r2=368611&view=diff
==============================================================================
--- llvm/trunk/unittests/TextAPI/TextStubV1Tests.cpp (original)
+++ llvm/trunk/unittests/TextAPI/TextStubV1Tests.cpp Mon Aug 12 12:51:34 2019
@@ -147,8 +147,6 @@ TEST(TBDv1, ReadFile2) {
   EXPECT_EQ(0U, File->reexportedLibraries().size());
 }
 
-// Disable test for windows.
-#ifndef _WIN32
 TEST(TBDv1, WriteFile) {
   static const char tbd_v1_file3[] =
       "---\n"
@@ -214,7 +212,6 @@ TEST(TBDv1, Platform_macOS) {
   EXPECT_EQ(FileType::TBD_V1, File->getFileType());
   EXPECT_EQ(PlatformKind::macOS, File->getPlatform());
 }
-#endif // _WIN32
 
 TEST(TBDv1, Platform_iOS) {
   static const char tbd_v1_platform_ios[] = "---\n"

Modified: llvm/trunk/unittests/TextAPI/TextStubV2Tests.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/TextAPI/TextStubV2Tests.cpp?rev=368611&r1=368610&r2=368611&view=diff
==============================================================================
--- llvm/trunk/unittests/TextAPI/TextStubV2Tests.cpp (original)
+++ llvm/trunk/unittests/TextAPI/TextStubV2Tests.cpp Mon Aug 12 12:51:34 2019
@@ -171,8 +171,6 @@ TEST(TBDv2, ReadFile2) {
   EXPECT_EQ(0U, File->reexportedLibraries().size());
 }
 
-// Disable test for windows.
-#ifndef _WIN32
 TEST(TBDv2, WriteFile) {
   static const char tbd_v2_file3[] =
       "--- !tapi-tbd-v2\n"
@@ -224,7 +222,6 @@ TEST(TBDv2, WriteFile) {
   EXPECT_FALSE(Result);
   EXPECT_STREQ(tbd_v2_file3, Buffer.c_str());
 }
-#endif // _WIN32
 
 TEST(TBDv2, Platform_macOS) {
   static const char tbd_v1_platform_macos[] = "--- !tapi-tbd-v2\n"




More information about the llvm-commits mailing list