[PATCH] D66047: Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions to intrinsic calls

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 10:27:25 PDT 2019


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

LGTM, although I'm not generally familiar with the upgrader code.



================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:3871
+      if (!CI || CI->getCalledFunction() != Fn)
+        continue;
+
----------------
Intrinsic functions can't be used in any way except calling them, right?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66047/new/

https://reviews.llvm.org/D66047





More information about the llvm-commits mailing list