[PATCH] D64424: [AIX] Implement LR prolog/epilog save/restore

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 08:54:10 PDT 2019


hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/CodeGen/PowerPC/aix-lr.ll:13
+; 32BIT: stwu 1, -64(1)
+; 32BIT: bl .foo
+; 32BIT: nop
----------------
cebowleratibm wrote:
> hubert.reinterpretcast wrote:
> > Can we check for the stack pointer adjustment in the prologue? As it is, I am under the impression that the saved link register would be overwritten by the call.
> "stwu 1, -64(1)" is the SP adjustment in the prolog.  Why do you think the saved link register would be overwritten by the call?  This code saves the LR at offset 8 from SP, then saves the SP at offset 0 from SP and decrements SP by 64.
I missed that this was using the update form of the instruction. Sorry for the noise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64424/new/

https://reviews.llvm.org/D64424





More information about the llvm-commits mailing list