[llvm] r368564 - [llvm-ar][test] Correct tests marked as expected fails

Owen Reynolds via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 06:04:02 PDT 2019


Author: gbreynoo
Date: Mon Aug 12 06:04:02 2019
New Revision: 368564

URL: http://llvm.org/viewvc/llvm-project?rev=368564&view=rev
Log:
[llvm-ar][test] Correct tests marked as expected fails

In diff D64802 I marked three tests as expected failures for darwin but
James Nagurne saw these fail on his downstream embedded ARM cross
compiler.
I believe XFAIL: system-darwin should be used instead of using XFAIL:
darwin due to the problem being related to the darwin host and not the
target.

Differential Revision: https://reviews.llvm.org/D65745

Modified:
    llvm/trunk/test/tools/llvm-ar/extract.test
    llvm/trunk/test/tools/llvm-ar/mri-utf8.test
    llvm/trunk/test/tools/llvm-ar/print.test

Modified: llvm/trunk/test/tools/llvm-ar/extract.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-ar/extract.test?rev=368564&r1=368563&r2=368564&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-ar/extract.test (original)
+++ llvm/trunk/test/tools/llvm-ar/extract.test Mon Aug 12 06:04:02 2019
@@ -1,5 +1,5 @@
 ## Test extract operation.
-# XFAIL: darwin
+# XFAIL: system-darwin
 
 RUN: rm -rf %t && mkdir -p %t/extracted/
 

Modified: llvm/trunk/test/tools/llvm-ar/mri-utf8.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-ar/mri-utf8.test?rev=368564&r1=368563&r2=368564&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-ar/mri-utf8.test (original)
+++ llvm/trunk/test/tools/llvm-ar/mri-utf8.test Mon Aug 12 06:04:02 2019
@@ -1,5 +1,5 @@
 # Test non-ascii archive members
-# XFAIL: darwin
+# XFAIL: system-darwin
 
 RUN: rm -rf %t && mkdir -p %t/extracted
 

Modified: llvm/trunk/test/tools/llvm-ar/print.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-ar/print.test?rev=368564&r1=368563&r2=368564&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-ar/print.test (original)
+++ llvm/trunk/test/tools/llvm-ar/print.test Mon Aug 12 06:04:02 2019
@@ -1,5 +1,5 @@
 ## Test Print output
-# XFAIL: darwin
+# XFAIL: system-darwin
 
 RUN: rm -rf %t && mkdir -p %t
 RUN: echo file1 > %t/1.txt




More information about the llvm-commits mailing list