[PATCH] D66050: Improve division estimation of floating points.

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 03:43:42 PDT 2019


nemanjai added a comment.

I suppose this is essentially an RFC to gauge the community's interest in improving the algorithm to gain more precision.
I think that in order to pull the trigger on a change such as this we would need the following to happen:

1. The patch needs full context to be reviewable
2. The formatting needs to be fixed up (some lines too long, etc.)
3. We need testing (I imagine this makes a bunch of LIT tests fail which need to be updated)
4. b) It might not be a bad idea to add a test to `test-suite` that will do some fast division vs. non-fast division to make sure the accuracy isn't too bad
5. We should do some thorough analysis of the accuracy of the algorithm vs. the HW implementation on a wide range of values on a couple of targets (as was suggested above). I know this was done on PPC, so please share those results and try to replicate on another easily available target (such as X86).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66050/new/

https://reviews.llvm.org/D66050





More information about the llvm-commits mailing list