[PATCH] D66015: [llvm-strings] Improve testing of llvm-strings

[James Henderson via Phabricator via llvm-commits]

jhenderson updated this revision to Diff 214596.
jhenderson marked 8 inline comments as done.
jhenderson added a comment.

Addressed review comments:

- Made comments use double hash.
- Made some tests less brittle.
- Added extra test cases as suggested.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66015/new/

https://reviews.llvm.org/D66015

Files:
  test/tools/llvm-strings/Inputs/abcd
  test/tools/llvm-strings/Inputs/numbers
  test/tools/llvm-strings/Inputs/variable-length
  test/tools/llvm-strings/all-sections.test
  test/tools/llvm-strings/archive-filename.test
  test/tools/llvm-strings/eof-no-string.test
  test/tools/llvm-strings/eof.test
  test/tools/llvm-strings/file-filename.test
  test/tools/llvm-strings/help.test
  test/tools/llvm-strings/length.test
  test/tools/llvm-strings/multiple-inputs.test
  test/tools/llvm-strings/negative-char.test
  test/tools/llvm-strings/nested-archives.test
  test/tools/llvm-strings/option-grouping.test
  test/tools/llvm-strings/radix-filename.test
  test/tools/llvm-strings/radix.test
  test/tools/llvm-strings/response-file.test
  test/tools/llvm-strings/stdin-filename.test
  test/tools/llvm-strings/stdin.test
  test/tools/llvm-strings/terminator-neg.test
  test/tools/llvm-strings/terminator.test
  test/tools/llvm-strings/version.test
  test/tools/llvm-strings/whitespace.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66015.214596.patch
Type: text/x-patch
Size: 18277 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190812/1fc65040/attachment.bin>