[PATCH] D65643: unittests: Add a (centralized) ability to match std::error_code

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 01:52:40 PDT 2019


labath updated this revision to Diff 214588.
labath added a comment.
Herald added a subscriber: kristina.

Thanks for the feedback. I've redone the patch to add a std::error_code overload
to llvm::raw_ostream. This makes using std::error_code in tests "almost just
work", with the "almost" being there due to the ASSERT_TRUE problem.

I've dropped the matcher part of the patch because the need for it largely
disappears with this approach.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65643/new/

https://reviews.llvm.org/D65643

Files:
  include/llvm/Support/raw_ostream.h
  lib/Support/raw_ostream.cpp
  unittests/BinaryFormat/TestFileMagic.cpp
  unittests/Support/ErrorTest.cpp
  unittests/Support/FileOutputBufferTest.cpp
  unittests/Support/Host.cpp
  unittests/Support/Path.cpp
  unittests/Support/ProgramTest.cpp
  unittests/Support/ReplaceFileTest.cpp
  unittests/Support/raw_pwrite_stream_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65643.214588.patch
Type: text/x-patch
Size: 10318 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190812/b95e7249/attachment.bin>


More information about the llvm-commits mailing list