[compiler-rt] r368480 - Fix compilation after SVN r368476

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 14:06:48 PDT 2019


.../compiler-rt/lib/builtins/udivmoddi4.c:20:17: error: extra tokens
at end of #ifdef directive [-Werror,-Wextra-tokens]
#ifdef _MSC_VER && !defined(__clang__)
                               ^

-eric


On Fri, Aug 9, 2019 at 2:01 PM Martin Storsjö <martin at martin.st> wrote:
>
> That's surprising, it built fine for me at r368480. What errors did you
> see at r368480?
>
> // Martin
>
> On Fri, 9 Aug 2019, Eric Christopher wrote:
>
> > Looks like it's still broken. I've reverted this and r368476 in an
> > attempt to fix.
> >
> > -ericc
> >
> > On Fri, Aug 9, 2019 at 1:34 PM Martin Storsjo via llvm-commits
> > <llvm-commits at lists.llvm.org> wrote:
> >>
> >> Author: mstorsjo
> >> Date: Fri Aug  9 13:36:00 2019
> >> New Revision: 368480
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=368480&view=rev
> >> Log:
> >> Fix compilation after SVN r368476
> >>
> >> That revision broke compilation with this error:
> >>
> >> lib/builtins/fixunsxfdi.c:13:2: error: unterminated conditional directive
> >>  #if !_ARCH_PPC
> >>
> >> Modified:
> >>     compiler-rt/trunk/lib/builtins/fixunsxfdi.c
> >>
> >> Modified: compiler-rt/trunk/lib/builtins/fixunsxfdi.c
> >> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/fixunsxfdi.c?rev=368480&r1=368479&r2=368480&view=diff
> >> ==============================================================================
> >> --- compiler-rt/trunk/lib/builtins/fixunsxfdi.c (original)
> >> +++ compiler-rt/trunk/lib/builtins/fixunsxfdi.c Fri Aug  9 13:36:00 2019
> >> @@ -46,3 +46,4 @@ COMPILER_RT_ABI du_int __fixunsxfdi(long
> >>  #ifdef _MSC_VER && !defined(__clang__)
> >>  #pragma warning(pop)
> >>  #endif
> >> +#endif
> >>
> >>
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at lists.llvm.org
> >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >


More information about the llvm-commits mailing list