[PATCH] D65372: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy

[Mike Pozulp via Phabricator via llvm-commits]

mmpozulp updated this revision to Diff 214439.
mmpozulp marked 7 inline comments as done.
mmpozulp added a comment.

Rebaseline to get the new llvm-strip.rst docs page.
Incorporate feedback from @jhenderson to

1. Click "Done" boxes in phabricator. Thanks :)
2. Add @FILE check to help-message.test
3. Update llvm-strip.rst and llvm-objcopy.rst docs with @FILE option.
4. Remove the header re-ordering. I like it the way it was before.
5. Change response-file.test to a) use llvm-readobj to check sections,

and b) run cmp to show the output files are identical.
TODO: Try refactoring tools which call `cl::ExpandResponseFiles` to
avoid copy-pasting code from lib/Support/CommandLine.cpp like I did here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65372/new/

https://reviews.llvm.org/D65372

Files:
  llvm/docs/CommandGuide/llvm-objcopy.rst
  llvm/docs/CommandGuide/llvm-strip.rst
  llvm/test/tools/llvm-objcopy/ELF/help-message.test
  llvm/test/tools/llvm-objcopy/ELF/response-file.test
  llvm/tools/llvm-objcopy/CopyConfig.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65372.214439.patch
Type: text/x-patch
Size: 5481 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190809/244ae4c4/attachment-0001.bin>