[PATCH] D65352: [CodeGen] Require a name for a block addr target

Fri Aug 9 13:08:42 PDT 2019

void added a comment.

In D65352#1622024 <https://reviews.llvm.org/D65352#1622024>, @nickdesaulniers wrote:

> I think the comment in `LLVMTargetMachine::addAsmPrinter` about `// Don't waste memory on names of temp labels.` should be amended in this patch to say `... unless it's address is taken` or something to that effect.

I'm not sure about that. It might be confusing to people, as we aren't technically wasting memory if the block address is taken. Also, the boolean being set here seems to have slightly different semantics from the change I made.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65352/new/

https://reviews.llvm.org/D65352