[PATCH] D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3.

Fri Aug 9 10:07:29 PDT 2019

thakis added a comment.

In D63674#1609148 <https://reviews.llvm.org/D63674#1609148>, @delcypher wrote:

> > I think the way forward is for us to just make sure we have the full xcode available when building our clang package. But we need to figure out how to coax our infrastructure into making that happen..
>
> So is this fixed yet? There's no good reason for us to support your modified (broken) toolchain if there's no intention of fixing issues with it.

I'll try to look at this today.

It's not a modified toolchain, it's just Xcode without an iOS SDK.

In D63674#1609148 <https://reviews.llvm.org/D63674#1609148>, @delcypher wrote:

> > I think the way forward is for us to just make sure we have the full xcode available when building our clang package. But we need to figure out how to coax our infrastructure into making that happen..
>
> So is this fixed yet? There's no good reason for us to support your modified (broken) toolchain if there's no intention of fixing issues with it.

We've now updated our clang-building mac bots to have both a mac and an ios sdk. Let's reland this and see what happens. Thank you very much for your patience.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63674/new/

https://reviews.llvm.org/D63674