[PATCH] D65303: [BPI] Adjust the probability for floating point unordered comparison

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 09:40:55 PDT 2019


Carrot added inline comments.


================
Comment at: test/CodeGen/SystemZ/call-05.ll:456
 ; CHECK: br %r14
+; CHECK: br %r1
   %fun_a = load volatile void() *, void()** @fun_a;
----------------
scanon wrote:
> I know nothing about Z architecture; is this codegen change actually an improvement? What architectural considerations are at work here?
In this case, the machine code if conversion only considers branch and a target with non trivial probability, the original probability is 3/8, large enough to enable this if conversion. After reducing the probability, if conversion thinks it is too small, not worth the effort to optimize it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65303/new/

https://reviews.llvm.org/D65303





More information about the llvm-commits mailing list