[PATCH] D65977: [Attributor] Use IRPosition consistently

Hideto Ueno via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 09:10:05 PDT 2019


uenoku added a comment.

LGTM



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:158
+  static const IRPosition value(const Value &V, const Function &AnchorScope) {
+    // TODO: Determine if we need the scope at all.
+    if (auto *Arg = dyn_cast<Argument>(&V))
----------------
 What are the advantages to record the scope? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65977/new/

https://reviews.llvm.org/D65977





More information about the llvm-commits mailing list