[PATCH] D66015: [llvm-strings] Improve testing of llvm-strings

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht added a comment.
This revision is now accepted and ready to land.

Just one test that needs fixing, LGTM otherwise:



================
Comment at: test/tools/llvm-strings/version.test:4
+RUN: llvm-strings --version | FileCheck %s
+CHECK: LLVM version
----------------
This is actually testing the default cmake config; see this comment from `llvm/test/tools/llvm-readobj/basic.test`:

```
# Test version switch.
RUN: llvm-readobj --version | FileCheck %s --check-prefix=VERSION
RUN: llvm-readelf --version | FileCheck %s --check-prefix=VERSION
# In default configuration we could match "LLVM version", but the "LLVM" part
# can be changed with PACKAGE_NAME in CMake, so we match only version.
VERSION: version
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66015/new/

https://reviews.llvm.org/D66015