[PATCH] D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files.

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:422
+             +"Csects in the BSS can only contain a single symbol.");
+      Csect.Syms[0].SymbolTableIndex = Csect.SymbolTableIndex;
+    }
----------------
jasonliu wrote:
> We effectively only have BSS symbol's MCSection(CSect) entry in the symbol table, but not BSS symbol's MCSymbol.
> So BSS symbol's MCSymbol symbol table index should be the same as the BSS CSect's symbol table index, otherwise we would skip some symbol table index.  
Sorry... ignore the above comments. You already did what I think we should do. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65159/new/

https://reviews.llvm.org/D65159