[PATCH] D65992: [MachinePipeliner] Avoid indeterminate order in FuncUnitSorter

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 06:54:00 PDT 2019


jsji added a comment.

In D65992#1623010 <https://reviews.llvm.org/D65992#1623010>, @bcahoon wrote:

> Thanks for the patch! My only concern is with all the checks in the test case. Checking for the exact code sequence can be very sensitive to other changes in the compiler that are unrelated to this patch.
>
> Thanks,
> Brendon


Thanks Brendon! 
Yes, agree, the testcases was originally for James's refactoring, so far I added those CHECK intentionality to catch any potential impacts to machine pipeliner on PowerPC. 
I will relax the checks in all similar testcases later once machine pipeliner on PowerPC become stable enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65992/new/

https://reviews.llvm.org/D65992





More information about the llvm-commits mailing list