[PATCH] D65933: [X86] Simpily X86OptimizeLEAs.cpp. NFC

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 06:20:27 PDT 2019


RKSimon added a comment.

In D65933#1622789 <https://reviews.llvm.org/D65933#1622789>, @gpei wrote:

> In D65933#1620742 <https://reviews.llvm.org/D65933#1620742>, @RKSimon wrote:
>
> > I'm happy with making this pass properly public, but I'm not sure what you're gaining from splitting off X86MemOpKey.h - are you intending to reuse that code someplace else?
>
>
> It’s useful to us and it seemed like a generally good code reorganization.


In which case I'd recommend splitting the X86MemOpKey.h change into a separate followup patch and making this patch just about making the pass public.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65933/new/

https://reviews.llvm.org/D65933





More information about the llvm-commits mailing list